On Tue, Apr 12, 2022 at 10:48 PM Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote: > > On 4/11/22 16:28, Dave Jiang wrote: > > Subject: > > > > staging: r8188eu: fix multiple spelling errors in driver source > > > > Given that it already annotated that it's the r8188eu driver, no need to add "in > > driver r8188eu". > > > > Maybe the log can be something less terse: > > > > Fix multiple spelling errors reported by checkpatch. > > > > > > Probably doesn't hurt to fix other issues on the same line while you are at it. > > See below... > > Wrong on the first and last points. That subject is exactly what should be used > - it describes what is being modified. > > A given patch should fix one, and only one, problem. > > Yes, the commit message could be less terse, but that is not a problem. Ok so considering the last comment, I am sending version 2 of this patch with an appropriate commit message. > > Larry
