On Mon, Apr 11, 2022 at 11:13:05AM +0200, Johan Hovold wrote:
> On Mon, Apr 11, 2022 at 10:31:18AM +0200, Uwe Kleine-König wrote:
> > Since commit f9a8ee8c8bcd ("pwm: Always allocate PWM chip base ID
> > dynamically") the value held in base isn't used any more in the PWM
> > framework. All PMWs get assigned a dynamic ID, so the assignment is
> > redundant and can be dropped.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > ---
> > drivers/staging/greybus/pwm.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/greybus/pwm.c b/drivers/staging/greybus/pwm.c
> > index ad20ec24031e..3fda172239d2 100644
> > --- a/drivers/staging/greybus/pwm.c
> > +++ b/drivers/staging/greybus/pwm.c
> > @@ -297,7 +297,6 @@ static int gb_pwm_probe(struct gbphy_device *gbphy_dev,
> >
> > pwm->dev = &gbphy_dev->dev;
> > pwm->ops = &gb_pwm_ops;
> > - pwm->base = -1; /* Allocate base dynamically */
> > pwm->npwm = pwmc->pwm_max + 1;
> >
> > ret = pwmchip_add(pwm);
> >
> > base-commit: 3123109284176b1532874591f7c81f3837bbdc17
>
> I'd prefer if you added a "pwm: " module prefix to the summary (even if
> the previous patch to this driver didn't have that).
>
> Looks good to me otherwise:
>
> Reviewed-by: Johan Hovold <johan@xxxxxxxxxx>
Am I supposed to resend with the changed subject? Who will pick this up?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
