Re: [PATCH 1/6] staging: r8188eu: drop unnecessary wrapper rtw_free_cmd_priv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Vihas Makwana <makvihas@xxxxxxxxx>, Larry Finger <Larry.Finger@xxxxxxxxxxxx>, Phillip Potter <phil@xxxxxxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Michael Straube <straube.linux@xxxxxxxxx>
Subject: Re: [PATCH 1/6] staging: r8188eu: drop unnecessary wrapper rtw_free_cmd_priv
From: Joe Perches <joe@xxxxxxxxxxx>
Date: Sun, 10 Apr 2022 10:07:58 -0700
Cc: linux-staging@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Dan Carpenter <dan.carpenter@xxxxxxxxxx>, Pavel Skripkin <paskripkin@xxxxxxxxx>
In-reply-to: <20220410163117.3964-2-makvihas@gmail.com>
References: <20220410163117.3964-1-makvihas@gmail.com> <20220410163117.3964-2-makvihas@gmail.com>
User-agent: Evolution 3.40.4-1ubuntu2

On Sun, 2022-04-10 at 22:01 +0530, Vihas Makwana wrote:
> Remove the unnecessary wrapper. The logic of rtw_free_cmd_priv can
> be moved to _rtw_free_cmd_priv.

If you are going to drop wrappers, my preference would be
to drop the underscore prefixed ones.

Follow-Ups:
- Re: [PATCH 1/6] staging: r8188eu: drop unnecessary wrapper rtw_free_cmd_priv
  - From: Vihas Makwana

References:
- [PATCH 0/6] drop some unnecessary wrappers
  - From: Vihas Makwana
- [PATCH 1/6] staging: r8188eu: drop unnecessary wrapper rtw_free_cmd_priv
  - From: Vihas Makwana

Prev by Date: [PATCH 6/6] staging: r8188eu: drop unnecessary wrapper rtw_free_mlme_priv
Next by Date: Re: [PATCH 1/6] staging: r8188eu: drop unnecessary wrapper rtw_free_cmd_priv
Previous by thread: [PATCH 1/6] staging: r8188eu: drop unnecessary wrapper rtw_free_cmd_priv
Next by thread: Re: [PATCH 1/6] staging: r8188eu: drop unnecessary wrapper rtw_free_cmd_priv
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Development] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]