Hi Dan, On Thu, Apr 7, 2022 at 7:52 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > On Thu, Apr 07, 2022 at 06:57:24PM +0800, Kate Hsuan wrote: > > A not calibrated x_start setting would result in an incorrect AWB location > > configuration on a sensor when only the rightmost stripe is used. x_start > > should be calibrated by subtracting the stripe offset to set the coordinate > > to the correct position on the second stripe. > > > > I wish the commit description said more about what the bug looks like to > the user. This is the front facing camera, right? Is part of the video > blank or what's the deal? This is IPU3 image processor. I tried to fix the configuration issues on stripe 1 coordinate settings. > > > Signed-off-by: Kate Hsuan <hpa@xxxxxxxxxx> > > --- > > Correct the patch. The correction should be awb, not awb_fr. > > I tried to review the original patch and it was impossible. I saw > you're from an @redhat.com email address so I decided it must be right. > > I kind of get that you need to be a domain expert to review these > patches but this function is such a mess... Sorry for the misunderstanding in my comments. Since I made some mistakes on my v1 patch, so I had corrected this part and quickly sent the v2 patch. You are welcome to pinpoint the errors for my v2 patch. I could fix them. Thank you. > > regards, > dan carpenter > -- BR, Kate
