Re: [PATCH 1/5] staging: r8188eu: use round_up() instead of RND4()

Michael Straube <straube.linux@xxxxxxxxx> · Wed, 6 Apr 2022 16:56:37 +0200

On 4/6/22 11:54, Joe Perches wrote:
On Wed, 2022-04-06 at 08:18 +0200, Michael Straube wrote:
Use in-kernel round_up() instead of custom RND4().
[]

diff --git a/drivers/staging/r8188eu/core/rtw_security.c b/drivers/staging/r8188eu/core/rtw_security.c
[]
@@ -63,7 +63,7 @@ void rtw_wep_encrypt(struct adapter *padapter, struct xmit_frame *pxmitframe)
  				arc4_crypt(ctx, payload + length, crc.f1, 4);
  
  				pframe += pxmitpriv->frag_len;
-				pframe = (u8 *)RND4((size_t)(pframe));
+				pframe = (u8 *)round_up((size_t)pframe, 4);

Perhaps use PTR_ALIGN

				pframe = PTR_ALIGN(pframe, 4);

etc...

Sounds reasonable, I'll send v2 soon.

Thanks,
Michael








