From: Xiaoke Wang <xkernel.wang@xxxxxxxxxxx>
In r8712_xmit_resource_alloc(), if usb_alloc_urb() fails, there can be
some explored items are not released before this function returns.
Therefore, this patch re-explores the allocated items and uses
usb_free_urb() to release them.
Signed-off-by: Xiaoke Wang <xkernel.wang@xxxxxxxxxxx>
---
ChangeLog:
v1->v2 remove kmemleak_not_leak() and update the description.
drivers/staging/rtl8712/xmit_linux.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c
index 4a93839..034de02 100644
--- a/drivers/staging/rtl8712/xmit_linux.c
+++ b/drivers/staging/rtl8712/xmit_linux.c
@@ -113,9 +113,10 @@ int r8712_xmit_resource_alloc(struct _adapter *padapter,
pxmitbuf->pxmit_urb[i] = usb_alloc_urb(0, GFP_KERNEL);
if (!pxmitbuf->pxmit_urb[i]) {
netdev_err(padapter->pnetdev, "pxmitbuf->pxmit_urb[i] == NULL\n");
+ while (i-- > 0)
+ usb_free_urb(pxmitbuf->pxmit_urb[i]);
return -ENOMEM;
}
- kmemleak_not_leak(pxmitbuf->pxmit_urb[i]);
}
return 0;
}
--
