Rename macro arguments with CamelCase in upc.h as they are not accepted by checkpatch.pl Removed datatype in macro arguments. Since there are more than one checkpatch issue per line, more steps are rquired to fix. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@xxxxxxxxx> --- V1 -> V2: This patch was 4/7 and is now 3/6 --- drivers/staging/vt6655/upc.h | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/vt6655/upc.h b/drivers/staging/vt6655/upc.h index b374db5fca81..f080a25e6cdf 100644 --- a/drivers/staging/vt6655/upc.h +++ b/drivers/staging/vt6655/upc.h @@ -20,34 +20,34 @@ /* For memory mapped IO */ -#define VNSvInPortB(dwIOAddress, pbyData) \ - (*(pbyData) = ioread8(dwIOAddress)) +#define VNSvInPortB(io_address, data) \ + (*(data) = ioread8(io_address)) -#define VNSvInPortW(dwIOAddress, pwData) \ - (*(pwData) = ioread16(dwIOAddress)) +#define VNSvInPortW(io_address, data) \ + (*(data) = ioread16(io_address)) -#define VNSvInPortD(dwIOAddress, pdwData) \ - (*(pdwData) = ioread32(dwIOAddress)) +#define VNSvInPortD(io_address, data) \ + (*(data) = ioread32(io_address)) -#define VNSvOutPortB(dwIOAddress, byData) \ - iowrite8((u8)(byData), dwIOAddress) +#define VNSvOutPortB(io_address, data) \ + iowrite8((u8)(data), io_address) -#define VNSvOutPortW(dwIOAddress, wData) \ - iowrite16((u16)(wData), dwIOAddress) +#define VNSvOutPortW(io_address, data) \ + iowrite16((u16)(data), io_address) -#define VNSvOutPortD(dwIOAddress, dwData) \ - iowrite32((u32)(dwData), dwIOAddress) +#define VNSvOutPortD(io_address, data) \ + iowrite32((u32)(data), io_address) -#define PCAvDelayByIO(uDelayUnit) \ +#define PCAvDelayByIO(u_delay_unit) \ do { \ - unsigned char __maybe_unused byData; \ + unsigned char __maybe_unused data; \ unsigned long ii; \ \ - if (uDelayUnit <= 50) { \ - udelay(uDelayUnit); \ + if (u_delay_unit <= 50) { \ + udelay(u_delay_unit); \ } else { \ - for (ii = 0; ii < (uDelayUnit); ii++) \ - byData = inb(0x61); \ + for (ii = 0; ii < (u_delay_unit); ii++) \ + data = inb(0x61); \ } \ } while (0) -- 2.25.1