Re: [PATCH 7/7] staging: vt6655: Convert macro PCAvDelayByIO to function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Philipp Hortmann <philipp.g.hortmann@xxxxxxxxx>
Subject: Re: [PATCH 7/7] staging: vt6655: Convert macro PCAvDelayByIO to function
From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 3 Apr 2022 13:16:17 +0200
Cc: Forest Bond <forest@xxxxxxxxxxxxxxxxxxx>, linux-staging@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <b7551e92f42d60ff3bb74b5e28467f09781e3d06.1648882847.git.philipp.g.hortmann@gmail.com>
References: <cover.1648882847.git.philipp.g.hortmann@gmail.com> <b7551e92f42d60ff3bb74b5e28467f09781e3d06.1648882847.git.philipp.g.hortmann@gmail.com>

On Sat, Apr 02, 2022 at 09:29:49AM +0200, Philipp Hortmann wrote:
> Convert do-while(0) macro PCAvDelayByIO to function and relocate.

That says what you did, but not _why_ you did it.

Please read the kernel documentation again for how to write a good
changelog comment and resend a v2.

thanks,

greg k-h

References:
- [PATCH 0/7] staging: vt6655: Fix CamelCase in upc.h and started in mac.h
  - From: Philipp Hortmann
- [PATCH 7/7] staging: vt6655: Convert macro PCAvDelayByIO to function
  - From: Philipp Hortmann

Prev by Date: Re: [PATCH] staging: r8188eu: Fix unsafe memory access by memcmp.
Next by Date: Re: [PATCH] staging: r8188eu: Fix unsafe memory access by memcmp.
Previous by thread: Re: [PATCH 7/7] staging: vt6655: Convert macro PCAvDelayByIO to function
Next by thread: [PATCH 0/6] staging: r8188eu: cleanup
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Development] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]

Powered by Linux