On Fri, Apr 01, 2022 at 01:08:19AM +0800, xkernel.wang@xxxxxxxxxxx wrote: > ret = _r8712_init_sta_priv(&padapter->stapriv); > if (ret) > - return ret; > + goto free_recv_priv; > padapter->stapriv.padapter = padapter; > r8712_init_bcmc_stainfo(padapter); > r8712_init_pwrctrl_priv(padapter); > @@ -328,6 +328,18 @@ int r8712_init_drv_sw(struct _adapter *padapter) > init_default_value(padapter); > r8712_InitSwLeds(padapter); > return ret; Not related to the patch. (You didn't introduce this, so it's not something you need to fix.) But this "return ret;" would be better if it were "return 0;" regards, dan carpenter > + > +free_recv_priv: > + _r8712_free_recv_priv(&padapter->recvpriv); > +free_xmit_priv: > + _free_xmit_priv(&padapter->xmitpriv); > +free_mlme_priv: > + r8712_free_mlme_priv(&padapter->mlmepriv); > +free_evt_priv: > + r8712_free_evt_priv(&padapter->evtpriv); > +free_cmd_priv: > + r8712_free_cmd_priv(&padapter->cmdpriv); > + return ret; > }
