Re: [PATCH] staging: rtl8723bs: Fix No space before tabs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alaa!

Thank you for the patch

On March 31, 2022 thus sayeth Alaa Mohamed:
> Fix "WARNING: please, no space before tabs"
> reported by checkpatch
> 
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@xxxxxxxxx>
> ---
>  drivers/staging/rtl8723bs/core/rtw_efuse.c | 54 +++++++++++-----------
>  1 file changed, 27 insertions(+), 27 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index 3d3c77273026..06e727ce9cc2 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -100,7 +100,7 @@ u8 PwrState)
>  u16
>  Efuse_GetCurrentSize(
>  	struct adapter *padapter,
> -	u8 	efuseType,
> +	u8	efuseType,
>  	bool		bPseudoTest)
>  {
>  	return padapter->HalFunc.EfuseGetCurrentSize(padapter, efuseType,
> @@ -124,29 +124,29 @@ Efuse_CalculateWordCnts(u8 word_en)
>  }
>  
>  /*  */
> -/* 	Description: */
> -/* 		1. Execute E-Fuse read byte operation according as map offset and */
> -/* 		    save to E-Fuse table. */
> -/* 		2. Referred from SD1 Richard. */
> +/* Description: */
> +/*		1. Execute E-Fuse read byte operation according as map offset and */
> +/*			save to E-Fuse table. */
> +/*		2. Referred from SD1 Richard. */
>  /*  */
> -/* 	Assumption: */
> -/* 		1. Boot from E-Fuse and successfully auto-load. */
> -/* 		2. PASSIVE_LEVEL (USB interface) */
> +/* Assumption: */
> +/*		1. Boot from E-Fuse and successfully auto-load. */
> +/*		2. PASSIVE_LEVEL (USB interface) */
>  /*  */
> -/* 	Created by Roger, 2008.10.21. */
> +/* Created by Roger, 2008.10.21. */
>  /*  */
> -/* 	2008/12/12 MH	1. Reorganize code flow and reserve bytes. and add description. */
> -/* 					2. Add efuse utilization collect. */
> -/* 	2008/12/22 MH	Read Efuse must check if we write section 1 data again!!! Sec1 */
> -/* 					write addr must be after sec5. */
> +/* 2008/12/12 MH	1. Reorganize code flow and reserve bytes. and add description. */
> +/*					2. Add efuse utilization collect. */
> +/* 2008/12/22 MH	Read Efuse must check if we write section 1 data again!!! Sec1 */
> +/*					write addr must be after sec5. */
>  /*  */
>

I'm wondering if it would be OK if we removed the change history and 
tried to align the indentation a little. (This may need to be multiple 
patches depending on how everyone else feels)

It may help if we converted the comments into one block. eg:

   /* ... */
   /* ... */

to

  /*
   * ...
   * ...
   */

thank you again for the patch
~Bryan




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux