From: Xiaoke Wang <xkernel.wang@xxxxxxxxxxx> in rtw_os_xmit_resource_alloc(), if `pxmitbuf->pxmit_urb[i]` is allocated in failure, the other resources allocated by this function are not properly released. This patch is to free them. Signed-off-by: Xiaoke Wang <xkernel.wang@xxxxxxxxxxx> --- drivers/staging/r8188eu/os_dep/xmit_linux.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/r8188eu/os_dep/xmit_linux.c b/drivers/staging/r8188eu/os_dep/xmit_linux.c index 8c3f8f0..5a59f62 100644 --- a/drivers/staging/r8188eu/os_dep/xmit_linux.c +++ b/drivers/staging/r8188eu/os_dep/xmit_linux.c @@ -78,8 +78,12 @@ int rtw_os_xmit_resource_alloc(struct adapter *padapter, struct xmit_buf *pxmitb for (i = 0; i < 8; i++) { pxmitbuf->pxmit_urb[i] = usb_alloc_urb(0, GFP_KERNEL); - if (!pxmitbuf->pxmit_urb[i]) + if (!pxmitbuf->pxmit_urb[i]) { + while (i-- > 0) + usb_free_urb(pxmitbuf->pxmit_urb[i]); + kfree(pxmitbuf->pallocated_buf); return _FAIL; + } } return _SUCCESS; } --