On Wed, 30 Mar 2022 19:43:40 +0800, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
>> if (!pcmdpriv->rsp_allocated_buf) {
>> + kfree(pcmdpriv->cmd_allocated_buf);
>> + pcmdpriv->cmd_allocated_buf = NULL;
>> res = _FAIL;
>> goto exit;
>Shouldn't this be handled properly in the exit: portion instead?
I think this is ok since we do not need to free it in normal exit.
But if you like that, I can add an err label and move the operations
to there.
Or maybe we can directly return the status rather than changing
`res` since there are only two possibilities.
Regards,
Xiaoke Wang
