Re: [PATCH] staging: r8188eu: Fix sparse endianness warnings.

Dan Carpenter <dan.carpenter@xxxxxxxxxx> · Wed, 30 Mar 2022 10:11:00 +0300

On Tue, Mar 29, 2022 at 11:14:05PM -0400, Charlie Sands wrote:
> This patch fixes sparse warnings about the endianness of different
> integers in the driver.
> 
> Signed-off-by: Charlie Sands <sandsch@xxxxxxxxxxxxxxxxxxxxx>

Thanks!  This is a bugfix though so it needs a fixes tag.

Fixes: 15865124feed ("staging: r8188eu: introduce new core dir for RTL8188eu driver")

Otherwise:

Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

It's surprising that this code works at all.  I maybe have said before
that I suspect the pppoe stuff has not been well tested.

regards,
dan carpenter