Re: [PATCH] staging: r8188eu: Directly return _SUCCESS instead of using local ret variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Haowen Bai <baihaowen@xxxxxxxxx>
Subject: Re: [PATCH] staging: r8188eu: Directly return _SUCCESS instead of using local ret variable
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Tue, 29 Mar 2022 14:26:44 +0300
Cc: Larry Finger <Larry.Finger@xxxxxxxxxxxx>, Phillip Potter <phil@xxxxxxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, linux-staging@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <1648551967-23627-1-git-send-email-baihaowen@meizu.com>
References: <d293aee5-6065-9d87-0906-438542a8be84@meizu.com> <1648551967-23627-1-git-send-email-baihaowen@meizu.com>
User-agent: Mutt/1.9.4 (2018-02-28)

On Tue, Mar 29, 2022 at 07:06:06PM +0800, Haowen Bai wrote:
> @@ -534,9 +531,6 @@ u8 rtw_init_drv_sw(struct adapter *padapter)
>  free_mlme_ext:
>  	free_mlme_ext_priv(&padapter->mlmeextpriv);
>  
> -free_mlme_priv:
> -	rtw_free_mlme_priv(&padapter->mlmepriv);

No, we still need to free this on error.

regards,
dan carpenter

References:
- Re: 答复: [PATCH V2] staging: r8188eu: Directly return _SUCCESS instead of using local ret variable
  - From: baihaowen
- [PATCH] staging: r8188eu: Directly return _SUCCESS instead of using local ret variable
  - From: Haowen Bai

Prev by Date: [PATCH V3] staging: r8188eu: Directly return _SUCCESS instead of using local ret variable
Next by Date: Re: [PATCH V3] staging: r8188eu: Directly return _SUCCESS instead of using local ret variable
Previous by thread: Re: [PATCH V4] staging: r8188eu: Directly return _SUCCESS instead of using local ret variable
Next by thread: [PATCH V2] staging: r8188eu: Directly return _FAIL instead of using local ret variable
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Development] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]