Hi Sakari, On Thu, Mar 17, 2022 at 5:10 PM Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> wrote: > > On Thu, Mar 17, 2022 at 04:53:07PM +0800, Kate Hsuan wrote: > > Hi Sakari, > > > > On Thu, Mar 17, 2022 at 4:28 PM Sakari Ailus > > <sakari.ailus@xxxxxxxxxxxxxxx> wrote: > > > > > > On Thu, Mar 17, 2022 at 03:57:13PM +0800, Kate Hsuan wrote: > > > > For the AF configuration, if the rightmost stripe is used, the AF scene > > > > will be at the incorrect location of the sensor. > > > > > > > > The AF coordinate may be set to the right part of the sensor. This > > > > configuration would lead to x_start being greater than the > > > > down_scaled_stripes offset and the leftmost stripe would be disabled > > > > and only the rightmost stripe is used to control the AF coordinate. If > > > > the x_start doesn't perform any adjustments, the AF coordinate will be > > > > at the wrong place of the sensor since down_scaled_stripes offset > > > > would be the new zero of the coordinate system. > > > > > > > > In this patch, if only the rightmost stripe is used, x_start should > > > > minus down_scaled_stripes offset to maintain its correctness of AF > > > > scene coordinate. > > > > > > > > Changes in v2: > > > > 1. Remove the setting of the first stripe. > > > > > > > > Changes in v4: > > > > 1. x_start is estimated based on the method for both stripes are enabled. > > > > 2. x_end is estimated based on the width. > > > > > > Please put the changelog before '---' line. I've removed it from the commit > > > message this time. > > I meant to say after. Then it won't be part of the commit message. Thank you. I understand :) > > > > > > > -- > > > Sakari Ailus > > > > > > > Okay, I got it. > > > > Thank you. > > > > -- > > BR, > > Kate > > > > -- > Sakari Ailus > -- BR, Kate
