On Wed, Mar 02, 2022 at 06:36:38PM -0300, Gaston Gonzalez wrote: > Fix "no previous prototype" W=1 warning by adding the prototype of the > function vchiq_platform_init(). > > Note: vchiq_platform_init() is only called once in vchiq_probe(), so > presumably should be static function. However, making the function > static breaks the build. > > Signed-off-by: Gaston Gonzalez <gascoar@xxxxxxxxx> > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h > index 2aa46b119a46..d72edaf7e5e9 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h > @@ -122,6 +122,8 @@ vchiq_instance_get_trace(struct vchiq_instance *instance); > extern void > vchiq_instance_set_trace(struct vchiq_instance *instance, int trace); > > +int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state); > + It is a static function, so don't add a prototype here to say it is not :( thanks, greg k-h