Hi Sergio,
On 10/03/2022 14:50, Sergio Paracuellos wrote:
Hi Arinc,
Overall it looks good. See below my concerns.
On Thu, Mar 10, 2022 at 12:41 PM Arınç ÜNAL <arinc.unal@xxxxxxxxxx> wrote:
Fix the GB-PC2 devicetree. Refer to the schematics of the device for more
information.
GB-PC2 devicetree fixes:
- Include mt7621.dtsi instead of gbpc1.dts. Add the missing definitions.
There are pretty much the same definitions. Should we really include
mt7621 instead of gbpc1??
The DeviceTree Specification states that the name of include files
should end with “.dtsi”.
On top of that, we'd have to overwrite ethernet node's pinctrl-0
property again since we use a different value for GB-PC2 than GB-PC1.
Not to mention, GB-PC2 does not need gpio-leds node.
- Remove gpio-leds node as the system LED is not wired to anywhere on
the board and the power LED is directly wired to GND.
- Remove uart3 pin group from gpio-pinmux node as it's not used as GPIO.
- Use reg 7 for the external phy to be on par with
Documentation/devicetree/bindings/net/dsa/mt7530.txt.
Link: https://github.com/ngiger/GnuBee_Docs/blob/master/GB-PCx/Documents/GB-PC2_V1.1_schematic.pdf
Signed-off-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
---
drivers/staging/mt7621-dts/gbpc2.dts | 107 +++++++++++++++++++++++++--
1 file changed, 100 insertions(+), 7 deletions(-)
In any case, as I have said, looks good:
Reviewed-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>
Thanks,
Sergio Paracuellos
