On Wed, Mar 09, 2022 at 02:25:10AM +0530, Vihas Makwana wrote: > The code inside rtw_init_drv_sw() calls various init functions to > populate the padapter structure and checks for their return values > respectively. > But if one of the functions in middle fails then it simply returns > _FAIL instead of proper logging and calling freeing counterparts > of previous init functions. > This leads to various memory leaks and can be found in > /sys/kernel/debug/kmemleak if kernel is compiled with DEBUG_KMEMLEAK=y. > > Fix this and keep the success and error separate. > Delete the extra blank line. Feel free to add a Fixes tag which points to the driver add commit. Looks good. Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > Signed-off-by: Vihas Makwana <makvihas@xxxxxxxxx> > --- > Tested on Comfast CF-WU810N RTL8188EUS wireless adapter. > This patch depends on "[PATCH 1/2] staging: r8188eu: call _cancel_timer_ex from > _rtw_free_recv_priv" This is a patchset so that's assumed. No need to say it. Also it's not really true. Those patches are independent and can be applied in any order. regards, dan carpenter
