On Mon, Feb 21, 2022 at 08:20:14PM +0100, Michael Straube wrote: > On 2/21/22 13:22, Dan Carpenter wrote: > > On Sun, Feb 20, 2022 at 05:30:08PM +0100, Michael Straube wrote: > > > On 2/20/22 17:20, Pavel Skripkin wrote: > > Just from a review stand point it would be best to leave the original > > behavior. > > > > Do you mean to leave the whole original code including the 5 GHz > frequencies? Or returning a default value if we have a channel value < 1 > or > 14? I meant what Pavel said: if (channel == 0 || channel > ARRAY_SIZE(ch_freq_map)) return 2412; return ch_freq_map[channel - 1]; > > I'm a bit confused now, because Greg asked how we know that the driver > is only for 2.4 GHz chips. > Haven't you been deleting all the 5GHz code for some time now? Greg isn't saying you have to keep that if there is no reason. Just put the reason in the commit message and resend. regards, dan carpenter
