Hi Arinc, On Tue, Feb 15, 2022 at 9:50 AM Arınç ÜNAL <arinc.unal@xxxxxxxxxx> wrote: > > Hey Sergio, > > On 15/02/2022 11:35, Sergio Paracuellos wrote: > > Hi Arinc, > > > > On Tue, Feb 15, 2022 at 9:18 AM Arınç ÜNAL <arinc.unal@xxxxxxxxxx> wrote: > >> > >> GB-PC1 uses some of the rgmii2 pins (22 - 33) as GPIO. Therefore, the > >> rgmii2 bus cannot be used on this device. > >> Overwrite pinctrl-0 property under the ethernet node without rgmii2_pins on > >> the GB-PC1 devicetree. > >> > >> Signed-off-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx> > >> --- > >> drivers/staging/mt7621-dts/gbpc1.dts | 4 ++++ > >> 1 file changed, 4 insertions(+) > > > > No issues in GB-PC1. So: > > > > Tested-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx> > > Thanks for testing it so quickly! > > I was wondering if you got pinctrl errors on the bootlog before applying > this patch series. > > rgmii2 pin group is given gpio function so calling it from ethernet node > would cause this on my TP-Link RE650 v1 which also uses the rgmii2_pins > as GPIO. > > [ 1.177349] rt2880-pinmux pinctrl: pin io22 already requested by > pinctrl; cannot claim for 1e100000.ethernet > [ 1.196966] rt2880-pinmux pinctrl: pin-22 (1e100000.ethernet) status -22 > [ 1.210312] rt2880-pinmux pinctrl: could not request pin 22 (io22) > from group rgmii2 on device rt2880-pinmux > [ 1.230058] mtk_soc_eth 1e100000.ethernet: Error applying setting, > reverse things back > [ 1.245853] mtk_soc_eth: probe of 1e100000.ethernet failed with error -22 No, I was not getting any kind of error since when I test your last patch series I was not experimenting any kind of regression. I don't have any issues now also with your new patch series. Your new changes make sense since as you have said "rgmii2" pins are requested as GPIO but it seems are not really being requested? I don't have time to check the datasheet now but will try to get time to see what is happening there. Best regards, Sergio Paracuellos > > Arınç
