thanks for taking the time to review my patch On Fri, Feb 11, 2022 at 05:25:28PM +0300, Dan Carpenter wrote: > > I feel like this patch is over engineering your debug code. Is this > really worthwhile? If you really prefer the new format that's fine but > it seems like not necessarily a good use of energy. > After reflecting on it for while, I think that you and Greg are right not to like the approach taken. > > + } > > Instead of printing lineline at a time in a loop, what happens if you > just print size bytes? (I honestly don't know because I have never used > this function before). > It gets truncated as hex_dump_to_buffer prints at most 32 bytes. thanks, Paulo Almeida
