On Tue, Feb 08, 2022 at 09:09:10AM +0100, Fabio M. De Francesco wrote: > On martedì 8 febbraio 2022 00:42:10 CET Leonardo Araujo wrote: > > This patch fixes the following checkpatch.pl warning: > > > > CHECK: 'associcated' may be misspelled - perhaps 'associated'? > > > > Signed-off-by: Leonardo Araujo <leonardo.aa88@xxxxxxxxx> > > --- > > drivers/staging/r8188eu/core/rtw_ap.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > "Staging: r8188eu: core: 'associated' may be misspelled - perhaps 'associated'?" > it's not the way patch subjects are created for inclusion in Linux. I do not see anything wrong with this. What do you think is not acceptable? > Please follow what is clearly described in the "Philosophy of Linux kernel > patches" document at https://kernelnewbies.org/PatchPhilosophy... The in-kernel documentation describes this well also. > "In patch descriptions and in the subject, it is common and preferable to use > present-tense, imperative language. Write as if you are telling git what to do > with your patch.". > > It's not my job to accept or reject patches for this subsystem and I don't want > to tell you what to write but, if I were you, I'd send a v2 with a subject like > "Fix misspelled word in comments" (or something else similar to this subject). > > Furthermore, please take note that the name of this subsystem is "staging" (it > is not "Staging"). Either is fine, I will not reject a change for an upper-case letter like this. > Decide by yourself whether or not the other two patches that you submitted this > morning have to be sent anew as v2 with due changes in the subjects. I do not see a problem with this change at all, nothing needs to be resubmitted. greg k-h
