This patchset does the following to functions in ioctl_linux.c: - Remove unneeded return variable in some functions. These functions cannot be converted to void either because it is an iw_handler function or the function does return error code. - Propagate error code in rtw_p2p_get2 function - Convert some functions that always return 0 to return void v3 -> v4: - Split the changes into smaller patches to make it easier to review - Add a new patch to propagate error code in rtw_p2p_get2 function v2 -> v3: - Remove returns at the end of void functions to conform to coding style v1 -> v2: - As suggested by Greg, change functions that always return 0 and whose return value is not used, to return void instead. - Not removing return variables in rtw_p2p_get2 and rtw_p2p_set as they may need to be used. Abdun Nihaal (23): staging: r8188eu: remove unneeded variable in rtw_wx_get_essid staging: r8188eu: remove unneeded variable in rtw_wx_get_enc staging: r8188eu: remove unneeded variable in rtw_p2p_get staging: r8188eu: remove unneeded variable in rtw_p2p_get_wps_configmethod staging: r8188eu: remove unneeded variable in rtw_p2p_get_go_device_address staging: r8188eu: remove unneeded variable in rtw_p2p_get_device_type staging: r8188eu: remove unneeded variable in rtw_p2p_get_device_name staging: r8188eu: remove unneeded variable in rtw_p2p_get_invitation_procedure staging: r8188eu: propagate error code in rtw_p2p_get2 staging: r8188eu: convert rtw_p2p_set_go_nego_ssid to return void staging: r8188eu: convert rtw_p2p_setDN to return void staging: r8188eu: convert rtw_p2p_get_status to return void staging: r8188eu: convert rtw_p2p_get_req_cm to return void staging: r8188eu: convert rtw_p2p_get_role to return void staging: r8188eu: convert rtw_p2p_get_peer_ifaddr to return void staging: r8188eu: convert rtw_p2p_get_peer_devaddr to return void staging: r8188eu: convert rtw_p2p_get_peer_devaddr_by_invitation to return void staging: r8188eu: convert rtw_p2p_get_groupid to return void staging: r8188eu: convert rtw_p2p_get_op_ch to return void staging: r8188eu: convert rtw_p2p_invite_req to return void staging: r8188eu: convert rtw_p2p_set_persistent to return void staging: r8188eu: convert rtw_p2p_prov_disc to return void staging: r8188eu: convert rtw_p2p_got_wpsinfo to return void drivers/staging/r8188eu/os_dep/ioctl_linux.c | 155 +++++++------------ 1 file changed, 59 insertions(+), 96 deletions(-) -- 2.34.1