Hi, Am 27.01.22 um 02:44 schrieb cgel.zte@xxxxxxxxx: > From: "Minghao Chi (CGEL ZTE)" <chi.minghao@xxxxxxxxxx> > > 'destroy_workqueue()' already drains the queue before destroying it, > so there is no need to flush it explicitly. > > Remove the redundant 'flush_workqueue()' calls. are you sure that drain_workqueue() is the same as flush_workqueue()? > > Reported-by: Zeal Robot <zealci@xxxxxxxxxx> > Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@xxxxxxxxxx> > Signed-off-by: CGEL ZTE <cgel.zte@xxxxxxxxx> > --- > drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c > index 76d3f0399964..60305c63c6f6 100644 > --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c > +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c > @@ -1844,7 +1844,6 @@ int vchiq_mmal_finalise(struct vchiq_mmal_instance *instance) > mutex_unlock(&instance->vchiq_mutex); > > vchiq_shutdown(instance->vchiq_instance); > - flush_workqueue(instance->bulk_wq); > destroy_workqueue(instance->bulk_wq); > > vfree(instance->bulk_scratch);
