Hi Phillip, On 1/25/22 01:44, Phillip Potter wrote:
Remove all DBG_88E calls from core/rtw_mlme_ext.c, including the commented one, as they do not conform to kernel coding standards and are superfluous. Also restructure where appropriate to remove no longer needed code left behind by removal of these calls. This will allow the eventual removal of the DBG_88E macro itself. Signed-off-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx> ---
[code snip]
static u8 chk_ap_is_alive(struct adapter *padapter, struct sta_info *psta) @@ -7141,18 +6905,11 @@ static u8 chk_ap_is_alive(struct adapter *padapter, struct sta_info *psta) static void rtl8188e_sreset_linked_status_check(struct adapter *padapter) { u32 rx_dma_status = rtw_read32(padapter, REG_RXDMA_STATUS); - u8 fw_status;- if (rx_dma_status != 0x00) {- DBG_88E("%s REG_RXDMA_STATUS:0x%08x\n", __func__, rx_dma_status); + if (rx_dma_status != 0x00) rtw_write32(padapter, REG_RXDMA_STATUS, rx_dma_status); - }- fw_status = rtw_read8(padapter, REG_FMETHR);- if (fw_status == 1) - DBG_88E("%s REG_FW_STATUS (0x%02x), Read_Efuse_Fail !!\n", __func__, fw_status); - else if (fw_status == 2) - DBG_88E("%s REG_FW_STATUS (0x%02x), Condition_No_Match !!\n", __func__, fw_status); + rtw_read8(padapter, REG_FMETHR); }
Unused read. Can be dropped With regards, Pavel Skripkin
