Re: [PATCH 08/18] staging: vchiq_core: simplify vchiq_add_service_internal

[Pavel Skripkin <paskripkin@xxxxxxxxx>]

Hi Dan,

On 1/25/22 12:59, Dan Carpenter wrote:
[...]

> > > -	service->trace         = 0;
> > >   	atomic_set(&service->poll_flags, 0);
> >
> > Nit: atomic_set(0) can be also removed
>
> No, let's not write code that assumes it knows atomic_t internals.

Isn't atomic_set() just (let's say) "magic" write to memory in all 
cases? Am I missing some design issue here?




With regards,
Pavel Skripkin