Hi Kees, I love your patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Kees-Cook/staging-rtl-Check-for-NULL-header-value/20220115-122817 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git fa783154524a71ab74e293cd8251155e5971952b config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20220115/202201151724.U21w0KEg-lkp@xxxxxxxxx/config) compiler: riscv64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/0ee2a9ea6309b9087293fe3b38a76421998bff7d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Kees-Cook/staging-rtl-Check-for-NULL-header-value/20220115-122817 git checkout 0ee2a9ea6309b9087293fe3b38a76421998bff7d # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=riscv SHELL=/bin/bash drivers/staging/rtl8723bs/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/staging/rtl8723bs/core/rtw_recv.c: In function 'portctrl': >> drivers/staging/rtl8723bs/core/rtw_recv.c:468:15: error: 'precvframe' undeclared (first use in this function); did you mean 'precv_frame'? 468 | ptr = precvframe->u.hdr.rx_data; | ^~~~~~~~~~ | precv_frame drivers/staging/rtl8723bs/core/rtw_recv.c:468:15: note: each undeclared identifier is reported only once for each function it appears in vim +468 drivers/staging/rtl8723bs/core/rtw_recv.c 449 450 /* set the security information in the recv_frame */ 451 static union recv_frame *portctrl(struct adapter *adapter, union recv_frame *precv_frame) 452 { 453 u8 *psta_addr = NULL; 454 u8 *ptr; 455 uint auth_alg; 456 struct recv_frame_hdr *pfhdr; 457 struct sta_info *psta; 458 struct sta_priv *pstapriv; 459 union recv_frame *prtnframe; 460 u16 ether_type = 0; 461 u16 eapol_type = 0x888e;/* for Funia BD's WPA issue */ 462 struct rx_pkt_attrib *pattrib; 463 464 pstapriv = &adapter->stapriv; 465 466 auth_alg = adapter->securitypriv.dot11AuthAlgrthm; 467 > 468 ptr = precvframe->u.hdr.rx_data; 469 pfhdr = &precv_frame->u.hdr; 470 pattrib = &pfhdr->attrib; 471 psta_addr = pattrib->ta; 472 473 prtnframe = NULL; 474 475 psta = rtw_get_stainfo(pstapriv, psta_addr); 476 477 if (auth_alg == 2) { 478 if ((psta) && (psta->ieee8021x_blocked)) { 479 __be16 be_tmp; 480 481 /* blocked */ 482 /* only accept EAPOL frame */ 483 484 prtnframe = precv_frame; 485 486 /* get ether_type */ 487 ptr = ptr + pfhdr->attrib.hdrlen + pfhdr->attrib.iv_len + LLC_HEADER_LENGTH; 488 memcpy(&be_tmp, ptr, 2); 489 ether_type = ntohs(be_tmp); 490 491 if (ether_type == eapol_type) 492 prtnframe = precv_frame; 493 else { 494 /* free this frame */ 495 rtw_free_recvframe(precv_frame, &adapter->recvpriv.free_recv_queue); 496 prtnframe = NULL; 497 } 498 } else { 499 /* allowed */ 500 /* check decryption status, and decrypt the frame if needed */ 501 502 prtnframe = precv_frame; 503 /* check is the EAPOL frame or not (Rekey) */ 504 /* if (ether_type == eapol_type) { */ 505 /* check Rekey */ 506 507 /* prtnframe =precv_frame; */ 508 /* */ 509 /* else { */ 510 /* */ 511 } 512 } else 513 prtnframe = precv_frame; 514 515 return prtnframe; 516 } 517 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
