On Mon, Jan 10, 2022 at 12:37 PM Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote:
>
> On Mon, 2022-01-10 at 12:10 +0100, Sergio Paracuellos wrote:
> [...]
> > +static int mt7621_rst_xlate(struct reset_controller_dev *rcdev,
> > + const struct of_phandle_args *reset_spec)
> > +{
> > + unsigned long id = reset_spec->args[0];
> > +
> > + if (id == MT7621_RST_SYS)
>
> if (id == MT7621_RST_SYS || id >= rcdev->nr_resets)
>
> I forgot to mention that with .of_xlate set, the driver needs to check
> whether id < nr_resets on its own.
Oh, ok. I checked 'drivers/reset/reset-k210.c' as example and there
was only a similar check that I sent. Let me add this also and send
v8.
Best regards,
Sergio Paracuellos
>
> regards
> Philipp
