Re: [PATCH 02/56] staging: r8188eu: rename camelcase SetToDs to set_to_ds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 03, 2022 at 08:01:37PM +0100, Alberto Merciai wrote:
> Rename camel case macro SetToDs into set_to_ds.
> 
> Signed-off-by: Alberto Merciai <alb3rt0.m3rciai@xxxxxxxxx>
> ---
>  drivers/staging/r8188eu/core/rtw_mlme_ext.c | 4 ++--
>  drivers/staging/r8188eu/core/rtw_xmit.c     | 2 +-
>  drivers/staging/r8188eu/hal/rtl8188e_cmd.c  | 2 +-
>  drivers/staging/r8188eu/include/wifi.h      | 2 +-
>  4 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> index 0aa958f20cd6..6c784134d957 100644
> --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> @@ -5409,7 +5409,7 @@ static int _issue_nulldata(struct adapter *padapter, unsigned char *da, unsigned
>  	if ((pmlmeinfo->state & 0x03) == WIFI_FW_AP_STATE)
>  		SetFrDs(fctrl);
>  	else if ((pmlmeinfo->state & 0x03) == WIFI_FW_STATION_STATE)
> -		SetToDs(fctrl);
> +		set_to_ds(fctrl);

This patch will not be needed at all if you take my advice from patch
01.

The goal is to make readable code, not just rename things to pass a perl
script's suggestions :)

thanks,

greg k-h




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux