Smatch reported memory leak bug in rtl8723b_FirmwareDownload function. The problem is pFirmware memory is not released in 'release_fw1'. Instead of redirecting to 'release_fw1', we can turn it into 'exit' and free the memory. Signed-off-by: F.A. SULAIMAN <asha.16@xxxxxxxxxxxxxxx> --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c index f1fc077ed29c..5f09b3ef9459 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -361,7 +361,7 @@ s32 rtl8723b_FirmwareDownload(struct adapter *padapter, bool bUsedWoWLANFw) netdev_emerg(padapter->pnetdev, "Firmware size:%u exceed %u\n", pFirmware->fw_length, FW_8723B_SIZE); - goto release_fw1; + goto exit; } pFirmwareBuf = pFirmware->fw_buffer_sz; -- 2.17.1
