Hello, On Mon, Jan 03, 2022 at 02:28:40PM +0100, Greg KH wrote: > On Fri, Dec 31, 2021 at 10:55:27PM +0530, Abdun Nihaal wrote: > > Remove unneeded return variables in ioctl_linux.c that are initialized > > to 0 and are not assigned after. Instead, return 0 directly. > > Almost all of these should not be returning a value at all, if they can > not fail and no one checks the values, right? Yes. My bad. I saw that some of the functions were iw_handler functions and had assumed that all of them were iw_handler functions. > Please fix this up to be functions that return void, as that's the > correct thing to do here. Sure. I'll split it into two patches (one for iw_handler functions that need to return int, and one for functions whose return value are not used ) and send a v2 patchset. Thanks, Abdun Nihaal
