Thus wrote Michael Straube (straube.linux@xxxxxxxxx):
> The field bRDGEnable in struct hal_data_8188e is never set. It stays
> at its default value 0. Remove bRDGEnable and related dead code.
> Signed-off-by: Michael Straube <straube.linux@xxxxxxxxx>
> ---
> v3: no changes
> v2: no changes
> drivers/staging/r8188eu/hal/usb_halinit.c | 10 ----------
> drivers/staging/r8188eu/include/rtl8188e_hal.h | 3 ---
> 2 files changed, 13 deletions(-)
> diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
> index d5c7e8bf1f38..104705ef170e 100644
> --- a/drivers/staging/r8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/r8188eu/hal/usb_halinit.c
> @@ -384,13 +384,6 @@ static void _InitEDCA(struct adapter *Adapter)
> rtw_write32(Adapter, REG_EDCA_VO_PARAM, 0x002FA226);
> }
> -static void _InitRDGSetting(struct adapter *Adapter)
> -{
> - rtw_write8(Adapter, REG_RD_CTRL, 0xFF);
> - rtw_write16(Adapter, REG_RD_NAV_NXT, 0x200);
> - rtw_write8(Adapter, REG_RD_RESP_PKT_TH, 0x05);
> -}
> -
> static void _InitRetryFunction(struct adapter *Adapter)
> {
> u8 value8;
> @@ -712,9 +705,6 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter)
> value16 |= (MACTXEN | MACRXEN);
> rtw_write8(Adapter, REG_CR, value16);
> - if (haldata->bRDGEnable)
> - _InitRDGSetting(Adapter);
> -
> /* Enable TX Report */
> /* Enable Tx Report Timer */
> value8 = rtw_read8(Adapter, REG_TX_RPT_CTRL);
> diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> index b42af86555cd..e8cb093abb62 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> @@ -236,9 +236,6 @@ struct hal_data_8188e {
> u32 RfRegChnlVal[2];
> - /* RDG enable */
> - bool bRDGEnable;
> -
> /* for host message to fw */
> u8 LastHMEBoxNum;
> --
> 2.34.1
Acked-by: Martin Kaiser <martin@xxxxxxxxx>
