On Thu, Dec 30, 2021 at 11:56:33AM +0100, Greg KH wrote: > On Thu, Dec 23, 2021 at 10:56:15AM +1300, Paulo Miguel Almeida wrote: > > + /* > > + * rx_lock is used to avoid race-conditions that can be triggered from userspace. > > + * > > + * For instance, if a program in userspace is reading the char device > > + * allocated in this module then another program won't be able to change RX > > + * configuration of the RF69 hardware module via ioctl and vice versa. > > + * > > + * utilization summary: > > + * - pi433_read: blocks are read until rx read something (up to the buffer size) > > + * - pi433_ioctl: during pending read request, change of config not allowed > > + */ > > This is nice, but way too specific, and will quickly get out-of-date. > > How about something simple like: > /* Protects all rx_* variable accesses */ > I see your point. I will send a new version of this patch with your sugestion. Thanks for guidance. thanks, Paulo A.
