Re: [PATCH] media: max96712: fix unmet dependency on VIDEO_DEV for VIDEO_V4L2_SUBDEV_API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Julian,

Thanks for your work.

The issue is already fixed in [1].

1. https://git.linuxtv.org/media_stage.git/commit/?id=8cc464fdcaaef1a38423c79c29df96db397d8b69

On 2021-12-15 18:35:43 -0500, Julian Braha wrote:
> When VIDEO_MAX96712 is selected,
> and VIDEO_DEV is not selected,
> Kbuild gives the following warning:
> 
> WARNING: unmet direct dependencies detected for VIDEO_V4L2_SUBDEV_API
>   Depends on [n]: MEDIA_SUPPORT [=y] && VIDEO_DEV [=n] && MEDIA_CONTROLLER [=y]
>   Selected by [y]:
>   - VIDEO_MAX96712 [=y] && STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && I2C [=y] && OF_GPIO [=y]
> 
> This is because VIDEO_MAX96712 selects VIDEO_V4L2_SUBDEV_API,
> without selecting or depending on VIDEO_DEV, despite
> VIDEO_V4L2_SUBDEV_API depending on VIDEO_DEV.
> 
> This unmet dependency bug was detected by Kismet,
> a static analysis tool for Kconfig. Please advise
> if this is not the appropriate solution.
> 
> Signed-off-by: Julian Braha <julianbraha@xxxxxxxxx>
> ---
>  drivers/staging/media/max96712/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/media/max96712/Kconfig b/drivers/staging/media/max96712/Kconfig
> index 258d47644cbd..117fadf81bd0 100644
> --- a/drivers/staging/media/max96712/Kconfig
> +++ b/drivers/staging/media/max96712/Kconfig
> @@ -3,6 +3,7 @@ config VIDEO_MAX96712
>  	tristate "Maxim MAX96712 Quad GMSL2 Deserializer support"
>  	depends on I2C
>  	depends on OF_GPIO
> +	depends on VIDEO_DEV
>  	select V4L2_FWNODE
>  	select VIDEO_V4L2_SUBDEV_API
>  	select MEDIA_CONTROLLER
> -- 
> 2.32.0
> 

-- 
Kind Regards,
Niklas Söderlund




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux