Re: [PATCH] staging: r8188eu: convert type of HalData in struct adapter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/7/21 11:14, Greg KH wrote:
On Mon, Dec 06, 2021 at 10:22:58AM +0100, Michael Straube wrote:
adapter->HalData is used in the GET_HAL_DATA macro all across the
driver code but nobody checks if its allocation in
rtl188eu_alloc_haldata() was successful or not.

To avoid errors when the allocation fails convert the type of field
HalData from void pointer to struct hal_data_8188eu. Remove
GET_HAL_DATA, rtl8188eu_alloc_haldata(), rtl8188e_free_hal_data().

Signed-off-by: Michael Straube <straube.linux@xxxxxxxxx>
---
Tested on x86_64 with InterTech DMG-02.

This doesn't apply to my tree anymore, due to the other changes that
were submitted for this driver.  Can you rebase and resend please?


Sure, I'll do.

Thanks,
Michael




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux