On Sat, Dec 04, 2021 at 10:29:10AM +0100, Greg Kroah-Hartman wrote: > On Sat, Dec 04, 2021 at 10:09:41AM +0100, Alberto Merciai wrote: > > On Sat, Dec 04, 2021 at 11:27:43AM +0300, Pavel Skripkin wrote: > > > Looks like this variable is set, but never used. Shouldn't it be just > > > removed? > > > > > > Same for max_channel (or byMaxChannel). > > > > To be honest, I would prefer leave them where they are. I'm only > > refactoring the code considering less the logic aspect. > > > > I don't know if these variables will become usefull in a second > > moment. > > Fix the code for today, do not worry about tomorrow for stuff like this. Wise word... :) > > Anyway, If you consider that this could be a good moment to remove > > them we can proceed. > > Please remove things like this that are not needed. I will proceed. Thanks, Alberto
