Re: [PATCH v3] staging: vt6655: refactor byRadioCtl to radio_ctl

[Pavel Skripkin <paskripkin@xxxxxxxxx>]

On 12/3/21 23:24, Alberto Merciai wrote:
> Replace camelcase hungarian notated variable "byRadioCtl"
> into linux kernel coding style equivalent variable "radio_ctl".
>
> Signed-off-by: Alberto Merciai <alb3rt0.m3rciai@xxxxxxxxx>
> ---
>
> v2 -> v3
> - replace typo inside mail message body
> v1 -> v2
> - Correct mail subject
>
>   drivers/staging/vt6655/device.h      | 2 +-
>   drivers/staging/vt6655/device_main.c | 8 ++++----
>   2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
> index c51eba94230d..245f992e5a23 100644
> --- a/drivers/staging/vt6655/device.h
> +++ b/drivers/staging/vt6655/device.h
> @@ -227,7 +227,7 @@ struct vnt_private {
>   	bool bPWBitOn;
>   
>   	/* GPIO Radio Control */
> -	unsigned char byRadioCtl;
> +	unsigned char radio_ctl;
>   	unsigned char byGPIO;
>   	bool hw_radio_off;
>   	bool bPrvActive4RadioOFF;
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index 897d70cf32b8..37a82550ca82 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -371,18 +371,18 @@ static void device_init_registers(struct vnt_private *priv)
>   
>   	priv->radio_off = false;
>   
> -	priv->byRadioCtl = SROMbyReadEmbedded(priv->port_offset,
> +	priv->radio_ctl = SROMbyReadEmbedded(priv->port_offset,
>   					      EEP_OFS_RADIOCTL);
>   	priv->hw_radio_off = false;
>   
> -	if (priv->byRadioCtl & EEP_RADIOCTL_ENABLE) {
> +	if (priv->radio_ctl & EEP_RADIOCTL_ENABLE) {
>   		/* Get GPIO */
>   		MACvGPIOIn(priv->port_offset, &priv->byGPIO);
>   
>   		if (((priv->byGPIO & GPIO0_DATA) &&
> -		     !(priv->byRadioCtl & EEP_RADIOCTL_INV)) ||
> +		     !(priv->radio_ctl & EEP_RADIOCTL_INV)) ||
>   		     (!(priv->byGPIO & GPIO0_DATA) &&
> -		     (priv->byRadioCtl & EEP_RADIOCTL_INV)))
> +		     (priv->radio_ctl & EEP_RADIOCTL_INV)))
>   			priv->hw_radio_off = true;
>   	}
>   

This one is odd. Code uses byRadioCtl as local storage to check register 
value within one function...

I might be missing something, but I think, it can be removed as well.




With regards,
Pavel Skripkin