On Tue, Nov 23, 2021 at 01:23:50AM +0530, Vihas Mak wrote: > remove unnecessary NULL check surrounding rtw_free_netdev(), as the check > is already performed inside rtw_free_netdev() in > drivers/staging/r8188eu/os_dep/osdep_service.c. > > Signed-off-by: Vihas Mak <makvihas@xxxxxxxxx> > --- > drivers/staging/r8188eu/os_dep/usb_intf.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c > index 5a35d9fe3fc9..392bd7868519 100644 > --- a/drivers/staging/r8188eu/os_dep/usb_intf.c > +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c > @@ -466,8 +466,7 @@ static void rtw_usb_if1_deinit(struct adapter *if1) > if1->hw_init_completed); > rtw_handle_dualmac(if1, 0); > rtw_free_drv_sw(if1); > - if (pnetdev) > - rtw_free_netdev(pnetdev); > + rtw_free_netdev(pnetdev); As Dan said, this isn't usually a good idea to hide this. And are you sure this ever could be NULL? thanks, greg k-h
