On Mon, Nov 15, 2021 at 01:34:18AM +0300, Dmitry Osipenko wrote: > 15.11.2021 01:23, Dmitry Osipenko пишет: > > + vde->secure_bo = tegra_vde_alloc_bo(vde, DMA_FROM_DEVICE, 4096); > > + if (!vde->secure_bo) { > > + dev_err(dev, "Failed to allocate secure BO\n"); > > + goto err_pm_runtime; > > + } > > My eye just caught that by accident err variable isn't assigned to > -ENOMEM here. I'll make v2 shortly. Smatch has a check for this so we would have caught it. :) regards, dan carpenter