Thus wrote Fabio M. De Francesco (fmdefrancesco@xxxxxxxxx): > On Thursday, November 11, 2021 10:26:38 PM CET Martin Kaiser wrote: > > They are used only in a (disabled) debug print. > > In practice, lsusb can be used to read the actual vid and pid. > Hi Martin, > You seem to have overlooked the usual rules for writing conformant commit > messages :) > Please say "what" you did along with "why" you made the changes. > Here, and in two or three other patches of your series, you forgot to > describe "what" you did. You actually wrote it in the "Subject" lines but, as > you know for sure, commit messages must be self-contained entities. Hi Fabio, thanks for the reminder. The commit message should indeed make sense without the title. > Also, it would be nice to have a cover letter and have all seven patches in > one thread in response to the above, even if it (AFAIK) is not strictly > required. There wasn't a common topic in this series so I decided to add no cover letter. Best regards, Martin
