Re: [PATCH v2 0/4] media: HEVC: RPS clean up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Le 12/10/2021 à 16:35, Benjamin Gaignard a écrit :
This series aims to clean up Reference Picture Set usage and flags.

Long term flag was named with RPS prefix while it is not used for RPS
but for mark long term references in DBP. Remane it and remove the two
other useless RPS flags.

Clarify documentation about RPS lists content and make sure that Hantro
driver use them correctly (i.e without look up in DBP).

This series generates feedback about what is missing to move HEVC uAPI
out of staging but lack of remarks about the proposed changes themselves.
Does someone has an opinion about this RPS flag clean up ?

Regards,
Benjamin


These patches are the last in my backlog impacting HEVC uAPI.
 From my point of view, once they get merged, you could start talking
about how move HEVC uAPI to stable.

version 2:
- change DPB field name from rps to flags

Please note that the only purpose of commits 3 and 4 is to allow to test
G2 hardware block for IMX8MQ until a proper solution isuing power domain
can be found. Do not merge them.

GStreamer HEVC plugin merge request can be found here:
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1079

With those piece of code fluster score is 77/147.

Benjamin

Benjamin Gaignard (4):
   media: hevc: Remove RPS named flags
   media: hevc: Embedded indexes in RPS
   media: hantro: Use syscon instead of 'ctrl' register
   arm64: dts: imx8mq: Add node to G2 hardware

  .../media/v4l/ext-ctrls-codec.rst             | 14 +++---
  arch/arm64/boot/dts/freescale/imx8mq.dtsi     | 43 +++++++++++++----
  drivers/staging/media/hantro/hantro.h         |  5 +-
  .../staging/media/hantro/hantro_g2_hevc_dec.c | 27 +++--------
  drivers/staging/media/hantro/imx8m_vpu_hw.c   | 48 ++++++++++++-------
  .../staging/media/sunxi/cedrus/cedrus_h265.c  |  2 +-
  include/media/hevc-ctrls.h                    |  6 +--
  7 files changed, 84 insertions(+), 61 deletions(-)





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux