Em Mon, 8 Nov 2021 00:39:38 +0100 Hans de Goede <hdegoede@xxxxxxxxxx> escreveu: > Hi, > > On 10/21/21 11:52, Tsuchiya Yuto wrote: > > Thank you for your comment :-) > > > > First, I need to correct what I said in the previous mail. I later found > > that loading only "atomisp" (as well as its dependency, > > atomisp_gmin_platform) does not cause this issue. > > > > What causes this issue is rather, loading sensor drivers (as well as its > > dependency, atomisp_gmin_platform). > > > > These sensor drivers for surface3 are both not upstream, but I made them > > as similar as possible to the upstreamed ones. So, I guess this issue > > can still be reproducible on some other devices. > > I've run some test on my own surface3 and the problem is the writing > of 0x62 (which becomes just 0x02) to the 0x57 register of the PMIC, > writing 0x00 to that after loading the sensor driver makes things work > again. > > I have not had time to investigate this further. > > I used media-staging + your sensor drivers from: > https://github.com/kitakar5525/surface3-atomisp-cameras.git > > Which was enough to figure this out, but I've not actually gotten > either of the cameras working :| I get: > > [user@fedora nvt]$ ./atomisp-test.sh > p0: OPEN video device `/dev/video2' After the patch that moved the output preview to be the first one, you should probably use /dev/video0 here: $ v4l2-ctl -D -d /dev/video0|grep Name Name : ATOMISP ISP PREVIEW output $ v4l2-ctl -D -d /dev/video2|grep Name Name : ATOMISP ISP VIEWFINDER output On Asus T101HA, I'm also getting this if I use /dev/video2 with nvt: ioctl(3, _IOC(_IOC_WRITE, 0x76, 0xe0, 0x1f0), 0x7ffcf08fe030) = -1 EINVAL (Argumento inválido) p0: ./v4l2n: ATOMISP_IOC_S_PARAMETERS failed on fd 3: Invalid argument (22) p0: CLOSED video device Regards, Mauro
