Oh yeah, you're right. It never *just* does spinlocks (as stated in the commit message btw), it does spin_lock_bh() which bumps the soft IRQ count. > To summarize, I think that using in_interrupt() in the old wrappers was the > wiser choice. "Wiser" is not the right word. The wrappers were always stupid, but I guess they did work in this case so the fixes tag is correct. regards, dan carpenter