On Thu, Nov 04, 2021 at 07:33:36AM -0700, Joe Perches wrote: > On Thu, 2021-11-04 at 15:09 +0300, Dan Carpenter wrote: > > On Mon, Nov 01, 2021 at 02:31:59PM +0000, Karolina Drobnik wrote: > > > Add a local variable to store `MISCFIFO_SYNDATA_IDX` offset. > > > This change helps in shortening the lines in `rf.c` that > > > are deemed too long by checkpatch.pl. > > > > > > > I started reviewing the v1 patch but I should have been reviewing this > > patchset. Please don't do this. Leave the constant as a constant so > > we don't have to look it up. > > It's just an intermediate step to use idx++. > Personally, I'd combine patches to add and use idx++ directly. Yep. I saw that when I reviewed the later patches. This patch should be combined with those as you say. regards, dan carpenter
