This v4 patchset look good. Thanks! On Sat, Oct 23, 2021 at 01:05:49PM +0530, Kushal Kothari wrote: > @@ -2027,7 +2027,7 @@ void rtw_setstaKey_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pc > { > > struct sta_priv *pstapriv = &padapter->stapriv; > - struct set_stakey_rsp *psetstakey_rsp = (struct set_stakey_rsp *) (pcmd->rsp); > + struct set_stakey_rsp *psetstakey_rsp = (struct set_stakey_rsp *)(pcmd->rsp); ^^^^^^^^^^^ An unrelated note, if you wanted to send more patches. These extra parentheses could be removed. > struct sta_info *psta = rtw_get_stainfo(pstapriv, psetstakey_rsp->addr); > > if (!psta) > @@ -2042,7 +2042,7 @@ void rtw_setassocsta_cmdrsp_callback(struct adapter *padapter, struct cmd_obj * > struct sta_priv *pstapriv = &padapter->stapriv; > struct mlme_priv *pmlmepriv = &padapter->mlmepriv; > struct set_assocsta_parm *passocsta_parm = (struct set_assocsta_parm *)(pcmd->parmbuf); ^^^^^^^^^^^^^^^ Same here. > - struct set_assocsta_rsp *passocsta_rsp = (struct set_assocsta_rsp *) (pcmd->rsp); > + struct set_assocsta_rsp *passocsta_rsp = (struct set_assocsta_rsp *)(pcmd->rsp); ^^^^^^^^^^^^ Here. > struct sta_info *psta = rtw_get_stainfo(pstapriv, passocsta_parm->addr); > > if (!psta) regards, dan carpenter