On Sun, Oct 17, 2021 at 02:33:57PM +0200, Julia Lawall wrote: > > > On Sun, 17 Oct 2021, Stefan Wahren wrote: > > > Hi, > > > > Am 17.10.21 um 11:29 schrieb Kushal-kothari: > > > Fixed the warning:-msleep < 20ms can sleep for up to 20ms by replacing > > > msleep(unsigned long msecs) by usleep_range(unsigned long min, unsigned long max) > > > in usecs as msleep(1ms~20ms) can sleep for upto 20 ms. > > > > > > Signed-off-by: Kushal-kothari <kushalkothari285@xxxxxxxxx> > > > --- > > > > > > Changes from v1: Reword both the subject and the log message. > > > > > > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > > > index 6fbafdfe340f..80a7898c5331 100644 > > > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > > > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > > > @@ -857,7 +857,7 @@ vchiq_bulk_transmit(unsigned int handle, const void *data, unsigned int size, > > > if (status != VCHIQ_RETRY) > > > break; > > > > > > - msleep(1); > > > + usleep_range(1000, 2000); > > > > there was a recent discussion about this checkpatch warning [1] > > Should there be a comment about it? Even better would be an alternate wrapper around usleep(1) which would silence the checkpatch warning. Something like: #define short_sleep() usleep(1) regards, dan carpenter
