Em Tue, 2 Nov 2021 17:49:17 +0200 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> escreveu: > On Tue, Nov 02, 2021 at 06:05:23PM +0300, Dan Carpenter wrote: > > On Tue, Nov 02, 2021 at 04:45:20PM +0200, Andy Shevchenko wrote: > > > On Tue, Nov 2, 2021 at 4:44 PM Andy Shevchenko > > > <andy.shevchenko@xxxxxxxxx> wrote: > > > > On Tue, Nov 2, 2021 at 3:10 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > > > > On Mon, Oct 18, 2021 at 01:23:34AM +0900, Tsuchiya Yuto wrote: > > ... > > > > > > Run your patches through scripts/checkpatch.pl. > > > > > > > > While it's good advice, we are dealing with quite a bad code under > > > > staging, so the requirements may be relaxed. FYI, I fixed the checkpatch issue when I applied at media_stage: https://git.linuxtv.org/media_stage.git/commit/?id=8a5457b7c7c3b6aa1789b18bbaff9b6a99d74caa Ok, I could have instead replied to Tsuchiya instead, but, as Andy pointed, those patches solved longstanding issues at the atomisp driver. So, I just went ahead and cleaned up the issue ;-) > > > > > > To be more clear: the goal now is getting it _working_. That's why > > > this kind of noise is not important _for now_. > > > > If it's a new driver, then we accept all sorts of garbage, that's true. > > It was in kernel for a while, but never worked (hence anyhow tested) > up to the recent effort made by Tsuchiya. > > In any case, as I said, we shall run checkpatch in the future when > we have something working. Yeah, agreed. The best is to run checkpatch and save some time from the maintainers. In any case, as Andy pointed out, this driver still requires major cleanups everywhere. Yet, our current focus is to make it work with standard V4L2 apps. Regards, Mauro
