On 01/11/21 12:57 am, Pavel Skripkin wrote: > On 10/31/21 22:24, Pavel Skripkin wrote: >>> I think rtw_init_default_value should return void. It's return value is not useful. >> >> >> Sure, but you need to firstly remove >> `ret8 = rtw_init_default_value(padapter);` and then make it return bool > ^^^^ > > I mean void, of course :) > > > With regards, > Pavel Skripkin Intention for this patch to remove the goto statement. I think removing a local variable for return value and changing the return type of function can be one separate patch. On this patch intent to remove the goto statement only. Regards, Saurav