On Fri, Oct 29, 2021 at 05:00:12PM -0300, Gaston Gonzalez wrote: > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h > index 3e50910ecba3..53a98949b294 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h > @@ -74,9 +74,7 @@ > ((fourcc) >> 8) & 0xff, \ > (fourcc) & 0xff > > -typedef u32 BITSET_T; > - > -static_assert((sizeof(BITSET_T) * 8) == 32); > +static_assert((sizeof(u32) * 8) == 32); This assert is now pointless and should be removed. Your patch has already been applied so you can send a new follow on patch to do that. Also the BITSET_* stuff should be converted to normal kernel bitfield macros which use unsigned long pointers and set/clear/test_bit(). This conversion is slightly more complicated so don't worry about it if you don't want to. regards, dan carpenter
