On Mon, 2021-11-01 at 09:58 +0530, Saurav Girepunje wrote: > On 01/11/21 12:47 am, Joe Perches wrote: > > On Sun, 2021-10-31 at 21:43 +0300, Pavel Skripkin wrote: > > > On 10/31/21 21:10, Saurav Girepunje wrote: > > > > Remove the goto statement from rtw_init_drv_sw(). In this function goto > > > > can be replace by return statement. As on goto label exit, function > > > > only return it is not performing any cleanup. Avoiding goto will > > > > improve the function readability. [] > > > And just `return _SUCCESS;` here. > > > > And maybe one day s/_SUCCESS/true/ and s/_FAIL/false/ > > with appropriate conversions to bool > > Yes this is another improvement possible on this function. Not just this function, globally in the driver.
